Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memote.jl #70

Merged
merged 9 commits into from
May 15, 2023
Merged

Improve memote.jl #70

merged 9 commits into from
May 15, 2023

Conversation

stelmo
Copy link
Collaborator

@stelmo stelmo commented May 12, 2023

Many many changes

@exaexa
Copy link
Collaborator

exaexa commented May 12, 2023

@stelmo pls nuke the big files from history; recommended way is to rebase -i and move the "removal" commit just below the commit that added them as a fixup.

test/memote.jl Outdated Show resolved Hide resolved
@stelmo
Copy link
Collaborator Author

stelmo commented May 13, 2023

Nuked the big files

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2023

Codecov Report

Patch coverage: 85.75% and project coverage change: -14.62 ⚠️

Comparison is base (c11ca82) 95.05% compared to head (c0ea642) 80.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #70       +/-   ##
===========================================
- Coverage   95.05%   80.43%   -14.62%     
===========================================
  Files          16       20        +4     
  Lines         607      593       -14     
===========================================
- Hits          577      477      -100     
- Misses         30      116       +86     
Impacted Files Coverage Δ
src/memote.jl 100.00% <ø> (ø)
src/memote/checks/Energy.jl 0.00% <ø> (-89.48%) ⬇️
src/memote/frontend.jl 71.60% <72.07%> (-9.94%) ⬇️
src/memote/utils.jl 50.00% <85.71%> (-50.00%) ⬇️
src/memote/checks/Reactions.jl 95.83% <95.83%> (ø)
src/memote/checks/Annotation.jl 100.00% <100.00%> (ø)
src/memote/checks/Basic.jl 100.00% <100.00%> (ø)
src/memote/checks/Biomass.jl 100.00% <100.00%> (ø)
src/memote/checks/Consistency.jl 100.00% <100.00%> (ø)
src/memote/checks/GPRAssociation.jl 100.00% <100.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stelmo
Copy link
Collaborator Author

stelmo commented May 13, 2023

/format

@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 262bd4c

github-actions bot pushed a commit that referenced this pull request May 13, 2023
triggered by @stelmo on PR #70
@stelmo
Copy link
Collaborator Author

stelmo commented May 13, 2023

/format

@stelmo stelmo requested a review from exaexa May 13, 2023 20:39
@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as dfa0f87

github-actions bot pushed a commit that referenced this pull request May 13, 2023
triggered by @stelmo on PR #70
@stelmo
Copy link
Collaborator Author

stelmo commented May 14, 2023

/format

triggered by @stelmo on PR #70
@github-actions
Copy link

✔️ Auto-formatting triggered by this comment succeeded, commited as 6559778

exaexa
exaexa previously approved these changes May 15, 2023
Copy link
Collaborator

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor things to check/fix but basically OK.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/memote/checks/Biomass.jl Outdated Show resolved Hide resolved
src/memote/checks/Biomass.jl Show resolved Hide resolved
src/memote/checks/Biomass.jl Outdated Show resolved Hide resolved
src/memote/checks/Network.jl Show resolved Hide resolved
src/memote/checks/Reactions.jl Outdated Show resolved Hide resolved
src/memote/utils.jl Show resolved Hide resolved
Co-authored-by: Mirek Kratochvil <miroslav.kratochvil@uni.lu>
@stelmo stelmo requested a review from exaexa May 15, 2023 07:32
@stelmo stelmo merged commit 2309123 into master May 15, 2023
4 checks passed
@stelmo stelmo deleted the sew-fix-user-issues branch May 15, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants