Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getty TGN blank id and label in primary result data (new indexing) #419

Open
2 of 3 tasks
elrayle opened this issue Apr 7, 2021 · 1 comment
Open
2 of 3 tasks

Comments

@elrayle
Copy link
Member

elrayle commented Apr 7, 2021

Description

In the primary results data, all results have blank string for id and label.

Query: https://lookup-int.ld4l.org/authorities/search/linked_data/getty_tgn_new_ld4l_cache?q=memphis&maxRecords=4&context=true

First 2 results:

{
  "uri": "http://vocab.getty.edu/tgn/2062394-place",
  "id": "",
  "label": "",
  "context": []
},
{
  "uri": "http://vocab.getty.edu/tgn/2080686-place",
  "id": "",
  "label": "",
  "context": []
},

Exploration

  • verify LDPaths for id and label are correct (See indexing speadsheet - Getty TGN tab)
  • verify cache is returning id and label for each result
  • verify primary result data is configured correctly in QA
@elrayle elrayle changed the title Getty TGN blank id and label in base data (new indexing) Getty TGN blank id and label in primary result data (new indexing) Apr 7, 2021
@elrayle
Copy link
Member Author

elrayle commented Apr 12, 2021

The label is in the data returned from the cache. QA config needs to be updated.

For id, the data at Getty included id = ^foaf:focus / dc:identifier triple, but I don't see it in the data returned from the cache.

<http://vocab.getty.edu/tgn/2069433> <http://purl.org/dc/elements/1.1/identifier> "2069433" .

For now, I will have the id set to the URI, but it is better to set it to the id when it is available in the data.

ACTIONS:

  • @elrayle - update the QA config for label to match the spreadsheet
  • @elrayle - temporarily set the id to the subject URI
  • @eichmann - update the indexing to include the dc:identifier in the results
  • @elrayle - switch id to dc:identifier when available in results

elrayle added a commit to cul-it/qa_server that referenced this issue Apr 12, 2021
This fixes the label for both TGN and ULAN.  It adds context for ULAN and fixes some errors in context for TGN.

id is set to the subject URI in this PR because `dc:identifier` is not in the search results.  See issues:

* [#419](LD4P/qa_server#419) - Getty TGN blank id and label in primary result data (new indexing)
* [#420](LD4P/qa_server#420) - Getty ULAN blank id and label in primary result data (new indexing)
elrayle added a commit that referenced this issue Apr 12, 2021
* fixes the ldpath for label in both TGN and ULAN
* fixes getty and skosxl prefixes in both
* adds context for ULAN
* expands context for TGN
* sets id to the subjectURI in the results

NOTE: id should be `dc:identifier`, but that predicate is not in the search results.

See issues:

* [#419](#419) - Getty TGN blank id and label in primary result data (new indexing)
* [#420](#420) - Getty ULAN blank id and label in primary result data (new indexing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant