Updates based on PR review

LD4P · Oct 24, 2019 · a4d9c2e · a4d9c2e
1 parent 7f5ee01
commit a4d9c2e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/__tests__/components/search/Search.test.js b/__tests__/components/search/Search.test.js
@@ -140,9 +140,8 @@ describe('<Search />', () => {
     expect(mockGetSearchResults).toBeCalledWith('foo', 0, 10, undefined, undefined)
 
     // Result
-    expect(await findByText('Your List of Bibliographic Metadata Stored in Sinopia')).toBeInTheDocument()
+    expect(await findByText('foo')).toBeInTheDocument()
 
-    expect(getByText('foo', { selector: 'td' })).toBeInTheDocument()
     expect(getByText('http://id.loc.gov/ontologies/bibframe/Title', { selector: 'li' }))
       .toBeInTheDocument()
   })

diff --git a/cypress/integration/end2end.spec.js b/cypress/integration/end2end.spec.js
@@ -88,7 +88,6 @@ describe('End-to-end test', () => {
     cy.get('input#searchInput')
       .type(`${title}{enter}`, { force: true })
 
-    cy.contains('Your List of Bibliographic Metadata Stored in Sinopia')
     cy.contains(title)
   })
 

diff --git a/src/components/search/SinopiaSearchResults.jsx b/src/components/search/SinopiaSearchResults.jsx
@@ -6,6 +6,7 @@ import { connect } from 'react-redux'
 import { bindActionCreators } from 'redux'
 import PropTypes from 'prop-types'
 import Config from 'Config'
+import shortid from 'shortid'
 import { getCurrentUser } from 'authSelectors'
 import { copyNewResource } from 'actions/index'
 import { retrieveResource } from 'actionCreators/resources'
@@ -48,9 +49,9 @@ const SinopiaSearchResults = (props) => {
   // TODO: Turn this function into a functional component
   const generateRows = () => {
     const rows = []
-    props.searchResults.forEach((row, _index) => {
+    props.searchResults.forEach((row) => {
       const link = `${Config.sinopiaServerBase}/${row.uri}`
-      rows.push(<tr key={_index}>
+      rows.push(<tr key={shortid.generate()}>
         <td>{ row.label }</td>
         <td>
           <ul className="list-unstyled">
@@ -90,8 +91,6 @@ const SinopiaSearchResults = (props) => {
       <div id="search-results" className="row">
         <div className="col-sm-2"></div>
         <div className="col-sm-8">
-          <h3>Your List of Bibliographic Metadata Stored in Sinopia</h3>
-
           <table className="table table-bordered" id="search-results-list">
             <thead>
               <tr>