Remove 'required' prop from Typeahead components

LD4P · Nov 7, 2019 · cbab6ae · cbab6ae
1 parent 7f139e1
commit cbab6ae
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 22 deletions.
diff --git a/__tests__/components/editor/property/InputListLOC.test.js b/__tests__/components/editor/property/InputListLOC.test.js
@@ -131,7 +131,6 @@ describe('InputListLOC', () => {
     expect(getByPlaceholderText('Sound characteristics')).toBeInTheDocument()
     // Not required.
     expect(queryByText('Required')).not.toBeInTheDocument()
-    expect(getByPlaceholderText('Sound characteristics')).not.toHaveAttribute('required')
     // No existing values are present. This sort of a query isn't recommended but since testing for absence, seems OK.
     expect(container.querySelector('.rbt-token')).not.toBeInTheDocument()
   })

diff --git a/__tests__/components/editor/property/InputLookupSinopia.test.js b/__tests__/components/editor/property/InputLookupSinopia.test.js
@@ -35,19 +35,6 @@ describe('<InputLookupSinopia />', () => {
     expect(wrapper.find('#sinopia-lookup').props().placeholder).toMatch('Name Lookup')
   })
 
-  it('sets the typeahead component required attribute according to the mandatory property from the template', () => {
-    expect(wrapper.find('#sinopia-lookup').props().required).toBeFalsy()
-  })
-
-  describe('when mandatory is true', () => {
-    const template = { ...plProps.propertyTemplate, mandatory: 'true' }
-    const wrapper2 = shallow(<InputLookupSinopia.WrappedComponent {...plProps} propertyTemplate={template} />)
-
-    it('is required', () => {
-      expect(wrapper2.find('#sinopia-lookup').props().required).toBeTruthy()
-    })
-  })
-
   it('sets the typeahead component multiple attribute according to the repeatable property from the template', () => {
     expect(wrapper.find('#sinopia-lookup').props().multiple).toBeFalsy()
   })

diff --git a/src/components/ResourceTemplateChoiceModal.jsx b/src/components/ResourceTemplateChoiceModal.jsx
@@ -67,7 +67,6 @@ const ResourceTemplateChoiceModal = (props) => {
               <AsyncTypeahead onSearch={search}
                               onChange={change}
                               options={options}
-                              required={false}
                               multiple={false}
                               isLoading={isLoading}
                               selected={selected}

diff --git a/src/components/editor/property/InputListLOC.jsx b/src/components/editor/property/InputListLOC.jsx
@@ -29,11 +29,9 @@ const InputListLOC = (props) => {
   })
 
   const [isRepeatable, setIsRepeatable] = useState(true)
-  const [isMandatory, setIsMandatory] = useState(false)
   const [lookupConfigs, setlookupConfigs] = useState([])
   useEffect(() => {
     setIsRepeatable(booleanPropertyFromTemplate(propertyTemplate, 'repeatable', true))
-    setIsMandatory(booleanPropertyFromTemplate(propertyTemplate, 'mandatory', false))
     setlookupConfigs(getLookupConfigItems(propertyTemplate))
   }, [propertyTemplate])
 
@@ -115,7 +113,6 @@ const InputListLOC = (props) => {
         allowNew={() => true }
         onChange={selected => selectionChanged(selected)}
         id="loc-vocab-list"
-        required={isMandatory}
         multiple={isRepeatable}
         placeholder={propertyTemplate.propertyLabel}
         emptyLabel="retrieving list of terms..."

diff --git a/src/components/editor/property/InputLookupQA.jsx b/src/components/editor/property/InputLookupQA.jsx
@@ -102,7 +102,6 @@ const InputLookupQA = (props) => {
     }
   }
 
-  const isMandatory = booleanPropertyFromTemplate(props.propertyTemplate, 'mandatory', true)
   const isRepeatable = booleanPropertyFromTemplate(props.propertyTemplate, 'repeatable', true)
 
   const setDisabled = () => {
@@ -136,7 +135,6 @@ const InputLookupQA = (props) => {
     <div className={groupClasses}>
       <AsyncTypeahead renderMenu={(results, menuProps) => renderMenuFunc(results, menuProps, props.propertyTemplate)}
                       ref={myInput}
-                      required={isMandatory}
                       disabled={setDisabled()}
                       onChange={(selected) => {
                         const payload = {

diff --git a/src/components/editor/property/InputLookupSinopia.jsx b/src/components/editor/property/InputLookupSinopia.jsx
@@ -28,7 +28,6 @@ const InputLookupSinopia = (props) => {
     return null
   }
 
-  const isMandatory = booleanPropertyFromTemplate(props.propertyTemplate, 'mandatory', false)
   const isRepeatable = booleanPropertyFromTemplate(props.propertyTemplate, 'repeatable', true)
 
   const search = (query) => {
@@ -77,7 +76,6 @@ const InputLookupSinopia = (props) => {
                       onChange={change}
                       onKeyDown={onKeyDown}
                       options={options}
-                      required={isMandatory}
                       multiple={isRepeatable}
                       isLoading={isLoading}
                       selected={props.selected}