Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets correct option key for URIs vs. strings #2064

Merged
merged 2 commits into from Jan 27, 2020
Merged

Conversation

jermnelson
Copy link
Contributor

@jermnelson jermnelson commented Jan 27, 2020

Currently the editor when is doing a lookup, if the user adds a valid URI (not found in the lookup itself) the correct label is being displayed but we're not adding an "uri"
Screen Shot 2020-01-27 at 1 43 26 PM

In the RDF preview, the following RDF is generated with both values being literals:
Screen Shot 2020-01-27 at 1 44 09 PM

This PR fixes this bug and results in the following:
Screen Shot 2020-01-27 at 1 47 22 PM

@jermnelson jermnelson marked this pull request as ready for review January 27, 2020 22:24
@jermnelson jermnelson merged commit acffdec into master Jan 27, 2020
@jermnelson jermnelson deleted the t2060-lookup-uri-check branch January 27, 2020 22:59
@jermnelson jermnelson mentioned this pull request Jan 28, 2020
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants