Removed building graph to see if resource has changed. #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jermnelson
requested changes
Jul 15, 2020
| const newSubject = { ...action.payload } | ||
| delete newSubject.properties | ||
| delete newSubject.subjectTemplate | ||
| newState.entities.subjects[action.payload.key] = newSubject | ||
|
|
||
| if (!_.isEqual(newSubject, subject)) { | ||
| newState.entities.subjects[newSubject.resourceKey].changed = true |
There was a problem hiding this comment.
I think setting this value to true is creating a regression because when a resource template is initially loaded and nothing has changed in the state, the Save button (src/components/editor/actions/SaveAndPublishButton) is enabled when it shouldn't be. Here is a screen shot just after the abbreviated title resource template is loaded with the save button enabled (should be disabled because nothing has changed):
There was a problem hiding this comment.
Fixed by setting changed to false after resource is loaded.
justinlittman
force-pushed
the
less_graph_building2
branch
from
6ba9e0b
to
2bca1a6
Compare
jermnelson
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the approach for determining if a resource has changed so that it does not rely on the GraphBuilder.