Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input list redux #260

Merged
merged 2 commits into from Dec 18, 2018
Merged

Input list redux #260

merged 2 commits into from Dec 18, 2018

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Dec 18, 2018

Fixes #259

  • Combined reducer for list and literal components
  • Changes InputList component to dispatch state to reducer action
  • Tests for modified component and list reducer
  • bumps up max-warnings to allow for security/detect-object-injection, but this is safe because user cannot inject anything in place of var i needed to parse the json to create the selection list

@coveralls
Copy link

coveralls commented Dec 18, 2018

Coverage Status

Coverage increased (+0.9%) to 85.649% when pulling b204fa7 on input-list-redux into 8fd9a4a on master.

Copy link
Contributor

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me,. Added suggestion to remove error about security/detect-object-injection warning.

src/components/editor/InputList.jsx Outdated Show resolved Hide resolved
@jermnelson jermnelson merged commit 59a2362 into master Dec 18, 2018
@jermnelson jermnelson deleted the input-list-redux branch December 18, 2018 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants