New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import a template from the Import Resource template tab and apply data in Editor tab #408
Conversation
… passed in as prop instead of state
…gpoints callback gets data
…e loaded as react-dom redirects and new state is passed to component to avoid warning about non-unique keys
question: will we be adding a list of links or a dropdown of starting points to the import tab, or don't we care at the moment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some questions -- it may be that they are all about concerns that have already been addressed with the current code base and the refactorings in progress.
There's a new design for the page where user can select a resource template to use. I'm not sure if it is in scope, but the users would like a table listing all the profiles, their IDs, and who it is associated with. @jermnelson @michelleif Is this correct, or are we reverting to the old design where it's just a list? |
Fixes #394
Removes the old "StartingPoints" box from the Editor tab and enables the new "ImportFileZone" box on the Import Resource Template tab. Once a file is uploaded and validated it will read the loaded data (same as before) but now it will redirect back to the Editor tab and set the Editor tab's state with the loaded template data.
The new text for the Import File Zone:
Loaded file and schema validation:
Redirect back to Editor tab with loaded data:
See the descriptions of the particular commits below...