Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import a template from the Import Resource template tab and apply data in Editor tab #408

Merged
merged 11 commits into from Mar 12, 2019

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented Mar 12, 2019

Fixes #394

Removes the old "StartingPoints" box from the Editor tab and enables the new "ImportFileZone" box on the Import Resource Template tab. Once a file is uploaded and validated it will read the loaded data (same as before) but now it will redirect back to the Editor tab and set the Editor tab's state with the loaded template data.

The new text for the Import File Zone:
Screen Shot 2019-03-12 at 3 14 26 PM

Loaded file and schema validation:
Screen Shot 2019-03-12 at 3 14 59 PM

Redirect back to Editor tab with loaded data:
Screen Shot 2019-03-12 at 3 15 10 PM

See the descriptions of the particular commits below...

@ndushay
Copy link
Contributor

ndushay commented Mar 12, 2019

question: will we be adding a list of links or a dropdown of starting points to the import tab, or don't we care at the moment?

Copy link
Contributor

@ndushay ndushay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some questions -- it may be that they are all about concerns that have already been addressed with the current code base and the refactorings in progress.

__tests__/integration/schemaValidation.test.js Outdated Show resolved Hide resolved
src/components/editor/ImportFileZone.jsx Show resolved Hide resolved
src/Config.js Show resolved Hide resolved
__tests__/components/editor/Editor.test.js Show resolved Hide resolved
@jgreben
Copy link
Contributor Author

jgreben commented Mar 12, 2019

@ndushay this is what the design from @astridu looks like. To me it seems like the import profile div and the standard profiles div would be separate components, the latter rendered below the one I renamed.

Screen Shot 2019-03-12 at 4 02 29 PM

@coveralls
Copy link

Coverage Status

Coverage increased (+1.0%) to 80.093% when pulling 3b1c4cc on update-editor-tab into a1de5db on master.

@ndushay ndushay merged commit 6eee5dc into master Mar 12, 2019
@ndushay ndushay deleted the update-editor-tab branch March 12, 2019 23:27
@astridu
Copy link

astridu commented Mar 12, 2019

There's a new design for the page where user can select a resource template to use. I'm not sure if it is in scope, but the users would like a table listing all the profiles, their IDs, and who it is associated with. @jermnelson @michelleif Is this correct, or are we reverting to the old design where it's just a list?
image

@jermnelson jermnelson mentioned this pull request Mar 13, 2019
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants