Test spaceless ids (refactor the schema validation tests) #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreben
changed the title
ndushay
approved these changes
Apr 25, 2019
| await page.waitForSelector('button#ImportProfile') | ||
| await page.click('button#ImportProfile') | ||
| await pupExpect(page).toMatch('select a file to upload:') | ||
| it('Displays and error message', async () => { |
ndushay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally about testing the "spaceless" IDs in the JSON schema (See LD4P/sinopia#201) but morphed into refatoring the schema validation tests to happen at the component/unit-test level in stead of integration tests (which were incomplete and error-prone). There is still one integration test for the malformed JSON test which was dificult to test at the unit-test level. A beneficial side-effect is that this refactoring increases overall code-coverage.