Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputlistloc selector reducer #513

Merged
merged 3 commits into from
May 7, 2019
Merged

Conversation

jgreben
Copy link
Contributor

@jgreben jgreben commented May 7, 2019

Fixes #430

  • Renames literal reducer to inputs because it is now being used by more than one input component
  • Add a redux function to set the selections from the typeahead option list. Selections are overwritten every time with everything in the selected array because the typeahead component keeps track of what's in there
  • Reorder the properties in the default payload to match what's set when selections are made
  • Remove the un-used rtId and add the reduxPath as needed by the new selectorReducer way of setting the redux state
  • Whether the typeahead component allows multiple selections should come from the repeatable property of the valueConstraint and not the property template.

…lueConstraint not the property temnplate itself; Reorder items in payload; remove unused rtId and add reducPath
@jgreben jgreben added this to Needs Review in Sinopia Work-Cycle One May 7, 2019
@jermnelson jermnelson assigned jermnelson and unassigned jermnelson May 7, 2019
Copy link
Contributor

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; very minor change suggestion.

src/reducers/inputs.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 77.599% when pulling deb1ad9 on inputlistloc-selector-reducer into 2d17295 on master.

@jermnelson jermnelson merged commit 9f88a3f into master May 7, 2019
Sinopia Work-Cycle One automation moved this from Needs Review to Done May 7, 2019
@jermnelson jermnelson deleted the inputlistloc-selector-reducer branch May 7, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

InputListLOC uses selectorReducer
3 participants