589 handle subauthorities #592
Conversation
|
@hudajkhan Can you also amend the test suites for |
|
Added a test for Config. Mulling over test for input qa. The changes to inputLookupQA were around identifying if a subauthority is passed from lookup config and then calling the right method from the apidoc. |
| @@ -7,6 +7,7 @@ import { connect } from 'react-redux' | |||
| import { getProperty } from '../../reducers/index' | |||
| import { changeSelections } from '../../actions/index' | |||
| import { booleanPropertyFromTemplate, defaultValuesFromPropertyTemplate } from '../../Utilities' | |||
| import Config from '../../../src/Config' | |||
There was a problem hiding this comment.
This component is already in the src/ directory, so I think the path should be '../../Config'
src/Config.js
Outdated
| @@ -63,6 +63,10 @@ class Config { | |||
| static get cognitoTestUserPass() { | |||
| return process.env.COGNITO_TEST_USER_PASS | |||
| } | |||
|
|
|||
| static get maxRecordsForQALookups() { | |||
| return process.env.MAX_RECORDS_FOR_QA_LOOKUPS || 8 | |||
There was a problem hiding this comment.
Looking good, @hudajkhan! Happy to merge this once the build goes 💚
|
Having an issue with the test I intended to evaluate the function for selecting the API. I'm commenting it out for now until I figure out how to do this properly (I'm also running into interesting challenges on being able to run tests on any of my local environments but that is a different story). thanks @jgreben for helping me step through some of it! |
|
Down to 0 errors and 12 warnings but the cutoff is 11 warnings. |
|
Hi, @hudajkhan! Yesterday, I believe @jermnelson said that your Sinopia time was running low. If you don't have time to knock out the last warning, I'd be happy to pick up this branch, work on the build, rebase on |
mjgiarlo
added this to the M04: Production of Original Data: Create and save data in Editor milestone
|
Hi @mjgiarlo ! If you could help me understand how to knock out that last warning (and maybe how to properly write the test), that would be great. I can then update the code. (fyi I slacked you too) |
mjgiarlo
force-pushed
the
589_handleSubauthorities
branch
from
ac0f27a
to
f567d32
Compare
mjgiarlo
force-pushed
the
589_handleSubauthorities
branch
from
f567d32
to
4c9d9cb
Compare
Fixes #589
Updated apidoc to enable calling all methods (spaces needed to be removed from tags) using current pattern for calls. If subauthority present, subauthority API call is made. Otherwise authority API is used.