WIP - tests no longer need test-config as LC verso is now open to CORS #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndushay
changed the title
ndushay
force-pushed
the
use-verso-urls
branch
from
e97d2ca
to
ee52c23
Compare
|
OMG - the CORS headings for verso must have changed a bunch of times as I worked to fix this. Ugh. Can't wait to get out of the verso dependency. |
ndushay
changed the title
ndushay
force-pushed
the
use-verso-urls
branch
from
3ae0c61
to
cc4469f
Compare
ndushay
changed the title
|
Not pursuing this further at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - do not merge. Is it possible circleci cannot get to verso?
test code can now use
http://bibframe.org/bibliomata/verso/apiurls, so no need to have test-config or test version of index.html to load test-config.Connected to #70