Fix Blank Screen when performing a Lookup #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgreben
force-pushed
the
fix-lookup-again
branch
from
a9d883c
to
890b116
Compare
jermnelson
requested changes
Jun 14, 2019
Check for undefined object for a key in CHANGE_SELECTIONS reducer
jgreben
force-pushed
the
fix-lookup-again
branch
from
890b116
to
9bb4410
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #712:
Similar to #684, if the lookup component has a
defaultURIdefined as an empty string, theTypeaheadComponentwill expect a label to go along with that default and without one will crash. This PR redefines when the defaults should return an empty array to that component.Fixes #718:
If the initial state of a redux resource object is undefined, and the defined property component assigns a
shortidin the redux path, the component crashes when trying to filter on an undefined object in that path, so check for that in the reducer when reassigning state.I ran across the bug surfaced in #718 while testing #712, so that's why this PR fixes both issues. I can split the PRs up if desired, but the changes here are not extensive.