Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

Add update_ecs job to Circle build, based on TACO and rialto-derivatives #123

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

atz
Copy link
Contributor

@atz atz commented Oct 31, 2018

Here's a build that completed and apparently updated the actual ECS container:
https://circleci.com/gh/LD4P/sinopia_profile_editor/530?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Note, because this job has nothing to do with the code (which is separately posted to docker hub) and only concerns itself with AWS commands, it uses an entirely different docker base image so that Python (and jq among other tools) is already installed!

You can review that CI output for effect. I then added the workflow relationship so that deployment only happens after successful register_image (i.e. only after merged to master).

@atz atz force-pushed the ecs_deploy branch 2 times, most recently from 41473eb to abe3cce Compare October 31, 2018 02:27
@coveralls
Copy link

coveralls commented Oct 31, 2018

Pull Request Test Coverage Report for Build 543

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 0.0%

Files with Coverage Reduction New Missed Lines %
source/assets/js/modules/profile/directives/export.directive.js 5 0.0%
Totals Coverage Status
Change from base Build 428: 0.0%
Covered Lines: 0
Relevant Lines: 1173

💛 - Coveralls

@atz atz force-pushed the ecs_deploy branch 2 times, most recently from d1bb2be to 200bd25 Compare October 31, 2018 02:47
@jermnelson
Copy link
Contributor

Looks good to me; I'll be interested to see a successful run the next time master is merged. I think @SaravShah would be the better reviewer to merge this branch.

@ndushay
Copy link
Contributor

ndushay commented Oct 31, 2018

I'm not looking at this closely right now, but ... what do you think of only dealing with the production npm install stuff if the tests pass and/or if we're in master branch? Just thought of it while waiting for an unrelated build to pass CI.

@atz
Copy link
Contributor Author

atz commented Oct 31, 2018

@ndushay It is a subset of of the npm install for CI. So doing it accomplishes part of the larger install and should be done first, in the same "job".

Secondly, the dependencies themselves are being cached, so it is very fast: 4 seconds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants