This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Spoof property types #128
Merged
Spoof property types #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atz
reviewed
Nov 1, 2018
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| *.zip | |||
| **/.DS_Store | |||
There was a problem hiding this comment.
The **/ isn't necessary here. .DS_Store would ignore any file of that name, anywhere in the repo.
ndushay
force-pushed
the
spoof-property-types
branch
from
050c3a4
to
54d9d7b
Compare
jermnelson
approved these changes
Nov 1, 2018
jermnelson
reviewed
Nov 1, 2018
| @@ -104,4 +101,16 @@ function loadOwlOntologies() { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| var owlOntUrlToXmlMappings = [] | |||
There was a problem hiding this comment.
This can be a const as to be more "ES6" ish, the type is immutable using const as an Array but not what you do with an Array.
jermnelson
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes this work:
Closes #92