Skip to content
This repository has been archived by the owner on Nov 26, 2020. It is now read-only.

indicate required fields with asterisk #198

Merged
merged 5 commits into from
Feb 14, 2019
Merged

indicate required fields with asterisk #198

merged 5 commits into from
Feb 14, 2019

Conversation

ndushay
Copy link
Contributor

@ndushay ndushay commented Feb 14, 2019

  • add asterisk to indicate required field to:
    • profile metadata: (tests added)
    • resource template metadata: rt id, resourceURI, resourceLabel, author
    • property template: propertyURI, propertyLabel, type
  • some small refactoring of existing tests to improve readability (indenting was messed up on one)
  • added tests that should have gone with don't display undesired attribs in app and don't put them in the JSON #166

Fixes #190

Before

image

After

requiredfields

@coveralls
Copy link

Pull Request Test Coverage Report for Build 817

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 807: 0.0%
Covered Lines: 0
Relevant Lines: 1198

💛 - Coveralls

Copy link
Contributor

@jermnelson jermnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; like the refactored integration tests

@jermnelson jermnelson merged commit abea996 into master Feb 14, 2019
@jermnelson jermnelson deleted the req-fields branch February 14, 2019 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants