Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Submodule Bump #1291

Merged
merged 2 commits into from
May 1, 2024
Merged

Last Submodule Bump #1291

merged 2 commits into from
May 1, 2024

Conversation

tomeichlersmith
Copy link
Member

@tomeichlersmith tomeichlersmith commented May 1, 2024

I am moving Tracking and TrigScint up to their lastest default branch (which I've tagged in those submodules) as the last submodules that need to be bumped.

What are the issues that this addresses?

Preparation for #1275

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.
  • I attached any sub-module related changes to this PR.

Related Sub-Module PRs

@tomeichlersmith
Copy link
Member Author

The failing plots are the same as for #1245

@tomeichlersmith tomeichlersmith marked this pull request as ready for review May 1, 2024 15:18
@tomeichlersmith tomeichlersmith merged commit d494b20 into trunk May 1, 2024
5 of 8 checks passed
@tomeichlersmith tomeichlersmith deleted the last-bump branch May 1, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant