Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wiki.ubuntu.com/WSL#Running_Graphical_Applications for the details.
Essentially, we are assuming that an X server is running somewhere and we point our container directly to the IP of that server. On linux systems, the X server (probably) requires no setup while on Windoze, the user will need to install some X server for WSL to connect to. We didn't have this problem before because the
DISPLAY
variable on Linux systems is set to:0
and some other nonsense can automagically connect to the X server. WSL can't do that.I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
This resolves #996 by pointing our container directly to the X server that is running.
Check List
I attached any sub-module related changes to this PR.NA