Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get Gerrit repos common util method #42

Closed
wants to merge 1 commit into from

Conversation

ajinkyan83
Copy link
Contributor

@ajinkyan83 ajinkyan83 commented Mar 1, 2021

da-metrics was dependent on sds lib for fetching gerrit repo count.
Updated code to have this as a util method in this repo.

Original source Ref: https://github.com/LF-Engineering/sync-data-sources/blob/master/sources/gerrit.go#L14

Related PR: https://github.com/LF-Engineering/dev-analytics-metrics/pull/254

Copy link
Contributor

@enkhalifapro enkhalifapro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lib not the right place for this logic

Copy link
Member

@lukaszgryglicki lukaszgryglicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ajinkyan83 ajinkyan83 closed this Mar 2, 2021
@ajinkyan83 ajinkyan83 deleted the fixtures-repo-count-cleanup branch March 2, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants