semantic changes to network examples #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
added 5 commits
February 21, 2019 09:23
|
Since PR #120 & #117 fixed some issues with setting synaptic parameters and activation times, this meant that the example network required an update to its parameters. This is what the output looks like now: Due to differences in some synaptic parameters, it is probably not possible to get back the exact state that resulted earlier. Additional fine tuning could probably bring it closer, but I'm not sure if it is worth the effort. |
|
Should add; the PR fixes some deprecated h5py and matplotlib codes, and supports Python3 as well. The Neurotools.parameters module has been swapped with a freestanding version that supports Python3. @torbjone , can I just merge this? |
|
Go ahead and merge! |
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.