Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed way of computing p_rad to avoid roundoff errors #142

Merged
merged 5 commits into from
Aug 21, 2019
Merged

Changed way of computing p_rad to avoid roundoff errors #142

merged 5 commits into from
Aug 21, 2019

Conversation

solveignaess
Copy link
Contributor

  • Simpler way of computing p_rad
  • Will avoid roundoff errors for large rz
  • Added new test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.844% when pulling c576575 on solveignaess:4Scleanup into 73b4f33 on LFPy:master.

torbjone
torbjone approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@torbjone torbjone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly looks better, and works on my end. The NaN that I saw earlier is gone.

@espenhgn espenhgn added this to the v2.1 milestone Aug 21, 2019
@espenhgn
Copy link
Collaborator

+1 also from me. Tx! Merging.

@espenhgn espenhgn merged commit 134129f into LFPy:master Aug 21, 2019
@solveignaess solveignaess deleted the 4Scleanup branch September 24, 2019 16:43
@solveignaess solveignaess mentioned this pull request Jan 30, 2020
Merged
@espenhgn espenhgn mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torbjone torbjone torbjone approved these changes

Assignees
No one assigned
Labels
bugfix enhancement
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@solveignaess @coveralls @espenhgn @torbjone