Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prediction errors with FourSphereVolumeConductor with offset dipoles #150

Merged
merged 13 commits into from
Feb 10, 2022

Conversation

espenhgn
Copy link
Contributor

@espenhgn espenhgn commented Feb 9, 2022

Closes #149

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

@espenhgn espenhgn added the bug fix fixes some issue label Feb 9, 2022
@espenhgn espenhgn added this to the Release 0.4 milestone Feb 9, 2022
Copy link
Collaborator

@torbjone torbjone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes fixes my problem, and all looks good. I tried to suggest some additional minor changes, but this ended up in a new PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintly has detected code quality issues in this pull request.

@espenhgn espenhgn mentioned this pull request Feb 10, 2022
@espenhgn espenhgn merged commit b759026 into master Feb 10, 2022
@espenhgn espenhgn deleted the fix-149 branch February 10, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix fixes some issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FourSphereVolumeConductor bug
2 participants