Download NY Head model files automatically if missing

[torbjone]

Switch to automatic downloading of New York Head model, if file location is not given.

Closes #193

[espenhgn]

I think this should capture URLError (as in URLError: <urlopen error [Errno -2] Name or service not known> or URLError: <urlopen error [Errno 8] nodename nor servname provided, or not known>), otherwise this looks good!

[torbjone]

I don't think URLError is a built-in error in python though, are you sure we should do this? I considered catching both PermissionError and URLErrors, but originally decided against it, since in the end I did not supply any more information than what was already effectively given in the error name.

[espenhgn]

URLError is raised by urllib which is part of the standard distribution. I think it is fine to capture it as well as PermissionError then. Having consecutive excepts should be ok, according to the docs:

import sys
try:
    f = open('myfile.txt')
    s = f.readline()
    i = int(s.strip())
except OSError as err:
    print("OS error:", err)
except ValueError:
    print("Could not convert data to an integer.")
except Exception as err:
    print(f"Unexpected {err=}, {type(err)=}")
    raise

[espenhgn]

Can you also bump the version number in LFPykit/version.py to 0.5.1?

[espenhgn]

URLError is raised by urllib which is part of the standard distribution. I think it is fine to capture it as well as PermissionError then. Having consecutive excepts should be ok, according to the docs:

import sys
try:
    f = open('myfile.txt')
    s = f.readline()
    i = int(s.strip())
except OSError as err:
    print("OS error:", err)
except ValueError:
    print("Could not convert data to an integer.")
except Exception as err:
    print(f"Unexpected {err=}, {type(err)=}")
    raise

[torbjone]

Does it look good now?

[espenhgn]

Excellent!