Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon hangs when disabling monitor #321

Closed
ettancos opened this issue May 31, 2024 · 1 comment · Fixed by #322
Closed

Daemon hangs when disabling monitor #321

ettancos opened this issue May 31, 2024 · 1 comment · Fixed by #322

Comments

@ettancos
Copy link
Contributor

ettancos commented May 31, 2024

Hi
I found an issue when I was trying to disable the laptop monitor on multi-monitor setup. The behavior was strange because swww-daemon was just hanging, no response for Ctrl+c, only kill -9 worked. Then I narrowed it down because when I enabled the display it got unstuck, that made me curious so I looked into it more.

In the end it looks like reading the payload is blocking when there is no payload (size = 0). In this case its the wl_output.done event.

I confirmed this by moving that section to an if size > 0 block and that seemed to have resolved it, not sure what is the rusty way to add that guard here. I might be missing something, don't know the wire level too much.

@LGFae
Copy link
Owner

LGFae commented May 31, 2024

Oh! Nice catch. That extra if statement seems to be exactly what we need. Do you want to make a PR with the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants