fix gif animations overlapping when sending two gifs #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gif animations were overlapping when an animated gif was sent while another animated gif was being displayed. This happened because we were setting `transition-finished` to `true` automatically when the animation token was dropped. So, when the previous gif animation stopped, it would drop the token and set `transition-finished` to true, even though the transition hadn't finished yet. This patch sets `transition-finished` manually, only for the transitions that actually finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gif animations were overlapping when an animated gif was sent while another animated gif was being displayed. This happened because we were setting
transition-finishedtotrueautomatically when the animation token was dropped. So, when the previous gif animation stopped, it would drop the token and settransition-finishedto true, even though the transition hadn't finished yet.This patch sets
transition-finishedmanually, only for the transitions that actually finished.Fixes #188.