wait for daemon initialization before certain requests #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swww {init,img,restore,clear} now waits for the daemon to initialize
before making the request
Fix: LGFae#224
|
I wonder if this also fixes #144. It seems like it would. |
LGFae
requested changes
Feb 25, 2024
There was a problem hiding this comment.
I like this idea a lot. The only thing besides what I've commented below is that maybe you could rename Request::Init to Request::Ping (this will also trigger a rename in its ArchivedRequest equivalent)? This would be more accurate to what we are doing now.
If it's too much work I can do it after merging too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swww {init,img,restore,clear}now waits for the daemon to initialize before making the request.Not sure if this is the best approach, but it seems to work ok.
Fix: #224