fix switching width and height #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not rouding the fractional scale properly, which led to the image being exactly one pixel off per row in certain configurations.
This allows `swww` to properly scale things on vertical monitors.
|
Great job, I can confirm that it works on my PC (multiple monitors, one of them vertical) too. |
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix called set_vertical before set_dimensions, causing the width and height to switch before getting their values. This PR add lock.is_vertical and swaps the weight and height in set_dimensions (after w and h receive their values) to resolve the issue.
This PR has been tested on my machine with a vertical monitor, and it functions correctly.