Typesafe IPC #331
Open
Typesafe IPC #331
+664
−517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No. You may break as many things as you want :) |
|
I noticed couple |
|
This should conclude first part if IPC refactor. In next PR I will reorganize daemon and client a bit to facilitate easier adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is first (and probably not last) PR for IPC refactor. For now this is a draft because I am unsure if PRs of this size are either to big or too inconsequential.
Apart from sending and receiving itself, I will take a look at some semi-duplicated code (looking at you,
RequestSendandRequestRecv), though this will not be included in this PR.Is there any form of compatibility guarantee between swww and swww-daemon if version bump ocuurs?