Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: The window movement track of the move-to-monitor command is repeated #912

Closed
MasouShizuka opened this issue Jul 12, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@MasouShizuka
Copy link
Contributor

MasouShizuka commented Jul 12, 2024

Describe the bug
When using the move-to-monitor command, the window's movement trajectory will repeat, as follows:

2024-07-12.09-47-54_batch.mp4

However, when using the send-to-monitor command, the window's motion trajectory is normal, as shown below:

2024-07-12.09-46-55_batch.mp4

To Reproduce
Steps to reproduce the behavior:

  1. Just use these two commands separately

Expected behavior
The window's movement trajectory of the move-to-monitor command is not repeated.

Operating System

OS 名称:          Microsoft Windows 11 家庭中文版
OS 版本:          10.0.22631 暂缺 Build 22631
@MasouShizuka MasouShizuka added the bug Something isn't working label Jul 12, 2024
@LGUG2Z
Copy link
Owner

LGUG2Z commented Jul 12, 2024

Similar issues have been reported generally with cross-monitor moves. I think the best way forward here for now is to disable animations in general for any operations that move windows across monitor or workspace boundaries.

@LGUG2Z LGUG2Z closed this as completed in bf59eb8 Jul 12, 2024
@MasouShizuka
Copy link
Contributor Author

This fix is ​​not appropriate.
If the intermediate code encounters a ? and throws an error, ANIMATION_ENABLED will not be restored to its original value.

LGUG2Z added a commit that referenced this issue Jul 12, 2024
There are quite a lot of janky animation bugs when moving window
containers across monitor and workspace boundaries.

This commit disables animation on all of the main cross-border window
container operations, meaning that animations should now only happen
within the context of a single workspace.

fix #912
@LGUG2Z
Copy link
Owner

LGUG2Z commented Jul 12, 2024

Updated the commit to follow the same pattern as when we temporarily disable borders:

pub static BORDER_TEMPORARILY_DISABLED: AtomicBool = AtomicBool::new(false);

This ensures that the value set for animation in the configuration will always be eventually consistent even if there are sporadic intermittent errors (subsequent successful calls that manipulate ANIMATION_TEMPORARILY_DISABLED will reset the value to false).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants