Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer manual control over Grace MS settings #282

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Offer manual control over Grace MS settings #282

merged 4 commits into from
Sep 19, 2023

Conversation

yasinparsi
Copy link

Fixes #281

@yasinparsi
Copy link
Author

If you want we can implement this for other classes like TumblingWindowOptions & HoppingWindowOptions

@LGouellec
Copy link
Owner

@yasinparsi
Can you implement the same behavior for TumblingWindowOptions and HoppingWindowOptions ? I think it could be interesting and useful.

Appreciate

@yasinparsi
Copy link
Author

@LGouellec
Ofcurse, I'll take care about it

@yasinparsi
Copy link
Author

@LGouellec
I've implemented

@LGouellec LGouellec merged commit 43d8a6e into LGouellec:develop Sep 19, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LGouellec LGouellec LGouellec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer manual control over Grace MS settings
2 participants
@yasinparsi @LGouellec