Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meshio/ffi: use std's c_int instead of libc's #231

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Conversation

hhirtz
Copy link
Member

@hhirtz hhirtz commented Sep 26, 2022

std defines std::ffi::c_int and std::os::raw::c_int, however the later module is marked as deprecated?

std defines std::ffi::c_int and std::os::raw::c_int, however the later
module is marked as deprecated?
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 51.11% // Head: 51.14% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (8652bc9) compared to base (fde3f5e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
+ Coverage   51.11%   51.14%   +0.02%     
==========================================
  Files          37       37              
  Lines        6873     6873              
==========================================
+ Hits         3513     3515       +2     
+ Misses       3360     3358       -2     
Impacted Files Coverage Δ
tools/mesh-io/ffi/src/lib.rs 0.68% <ø> (ø)
src/algorithms/vn/first.rs 92.98% <0.00%> (+1.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hhirtz hhirtz merged commit e8e658b into master Sep 26, 2022
@hhirtz hhirtz deleted the meshio-ffi-libc branch September 26, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant