Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hilbert: implement zorder for archs other than x86_64 #273

Closed
wants to merge 1 commit into from

Conversation

hhirtz
Copy link
Member

@hhirtz hhirtz commented Nov 24, 2022

  • for x86: use twice as many pdep32s and OR the results,
  • for other archs: loop over the bits. I didn't measure the performance.

Don't need this for now, and fallback code compiles to a lot of instructions, so I'll keep this PR open

Fixes #260

TODO

  • unit tests

- for x86: use twice as many `pdep32`s and OR the results,
- for other archs: loop over the bits. I didn't measure the performance.
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 55.47% // Head: 56.04% // Increases project coverage by +0.57% 🎉

Coverage data is based on head (ef30337) compared to base (7461d81).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   55.47%   56.04%   +0.57%     
==========================================
  Files          41       41              
  Lines        7530     7565      +35     
==========================================
+ Hits         4177     4240      +63     
+ Misses       3353     3325      -28     
Impacted Files Coverage Δ
src/algorithms/hilbert_curve.rs 85.92% <100.00%> (+0.96%) ⬆️
src/algorithms/vn/first.rs 91.22% <0.00%> (+0.87%) ⬆️
src/algorithms/arc_swap.rs 84.70% <0.00%> (+10.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cedricchevalier19
Copy link
Member

Related to #310

@cedricchevalier19 cedricchevalier19 marked this pull request as ready for review January 23, 2024 21:26
@cedricchevalier19
Copy link
Member

Already done in #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hilbert: support architectures other than x86_64
2 participants