Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cartesian: fix partition being transposed #286

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Conversation

hhirtz
Copy link
Member

@hhirtz hhirtz commented Jan 5, 2023

Since we start with coord=1, Grid::part_of must also be called with coord=1, otherwise the partition array ends up being transposed.

@hhirtz hhirtz enabled auto-merge (rebase) January 5, 2023 13:19
Since we start with coord=1, Grid::part_of must also be called with
coord=1, otherwise the partition array ends up being transposed.
@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 49.99% // Head: 43.76% // Decreases project coverage by -6.22% ⚠️

Coverage data is based on head (5c7dafe) compared to base (a8862c5).
Patch coverage: 25.00% of modified lines in pull request are covered.

❗ Current head 5c7dafe differs from pull request most recent head fb88706. Consider uploading reports for the commit fb88706 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   49.99%   43.76%   -6.23%     
==========================================
  Files          41       51      +10     
  Lines        7335     8685    +1350     
==========================================
+ Hits         3667     3801     +134     
- Misses       3668     4884    +1216     
Impacted Files Coverage Δ
tools/num-part/src/database/mod.rs 0.00% <0.00%> (ø)
tools/src/lib.rs 0.18% <0.00%> (ø)
src/cartesian/mod.rs 85.06% <50.00%> (ø)
tools/src/bin/mesh-dup.rs 3.84% <0.00%> (ø)
tools/src/bin/apply-weight.rs 1.92% <0.00%> (ø)
tools/src/bin/mesh-refine.rs 2.22% <0.00%> (ø)
tools/src/bin/weight-gen.rs 25.94% <0.00%> (ø)
tools/src/bin/mesh-reorder.rs 1.31% <0.00%> (ø)
tools/src/bin/part-info.rs 0.45% <0.00%> (ø)
tools/src/bin/mesh-part.rs 39.59% <0.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Introduced in clippy 1.66.0
@hhirtz hhirtz merged commit ac5b22e into master Jan 5, 2023
@hhirtz hhirtz deleted the fix-cartesian-part-of branch January 5, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant