Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include eager load relation #22

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

LIQRGV
Copy link
Owner

@LIQRGV LIQRGV commented Nov 30, 2022

This PR should resolve #20

With this PR, we can having relation eagerload using
some_model?include=other_model,other_model1

@LIQRGV LIQRGV force-pushed the feat/include-eager-load-relation branch 2 times, most recently from 4cb5524 to 0f52717 Compare November 30, 2022 09:31
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b5605a4) compared to base (8faec7c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##              master       #22   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        63        68    +5     
===========================================
  Files              5         5           
  Lines            173       192   +19     
===========================================
+ Hits             173       192   +19     
Impacted Files Coverage Δ
src/RequestParser.php 100.00% <100.00%> (ø)
src/Struct/ModelBuilderStruct.php 100.00% <100.00%> (ø)
src/Struct/FilterStruct.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LIQRGV LIQRGV force-pushed the feat/include-eager-load-relation branch from 0f52717 to 1cf0e6e Compare November 30, 2022 09:45
@LIQRGV LIQRGV closed this Nov 30, 2022
@LIQRGV LIQRGV reopened this Nov 30, 2022
@LIQRGV LIQRGV force-pushed the feat/include-eager-load-relation branch from 1cf0e6e to b5605a4 Compare November 30, 2022 09:49
@LIQRGV LIQRGV closed this Nov 30, 2022
@LIQRGV LIQRGV reopened this Nov 30, 2022
@LIQRGV LIQRGV merged commit 893c475 into master Nov 30, 2022
@LIQRGV LIQRGV deleted the feat/include-eager-load-relation branch November 30, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allowed Includes Relations
1 participant