Make session signatures compatible with SIWE ReCap #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will be further changes required and we should separate the logic out into its own package to localize this module with less concerns.
|
@hwrdtm this looks good. but is this live on the node yet? we have to handle it there too, right? or is there a PR? |
|
Closing in favor of #88 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
getSessionSigsfunction of@lit-protocol/lit-node-clientcompatible with EIP-5573 SIWE ReCap.@lit-protocol/authso that the concerns are better separated from@lit-protocol/lit-node-clientand are more localized. We know for sure that the ReCap standard will have at least one upcoming change as they become more compatible with UCANs.GetSessionSigPropsto be in@lit-protocol/lit-node-clientto avoid cyclical dependency tree and also better separation of concerns as, that belongs to the function call specific to theLitNodeClientanyways.Testing
Unit tests are implemented.
yarn test:packages