add optional labels to overlays. #1514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't do that on the right side, -there is no units but maybe indicators No good idea to make the right overlays free configurable, indicators do not change. therefore restricted configuration to OFF and default only
brunotl
requested changes
Dec 19, 2020
| for (int i=0; i<NumDataOptions; i++) { | ||
| dfe->addEnumText(LKGetText(Data_Options[i].Description)); | ||
| } | ||
| dfe->Sort(2); | ||
| dfe->Sort(2);*/ |
| dfe->addEnumText(LKGetText(Data_Options[i].Description)); | ||
| } | ||
| dfe->Sort(2); | ||
| dfe->Sort(2);*/ |
| dfe->addEnumText(LKGetText(Data_Options[i].Description)); | ||
| } | ||
| dfe->Sort(2); | ||
| dfe->Sort(2);*/ |
| @@ -336,6 +351,8 @@ void dlgOverlaysShowModal(void){ | |||
| else | |||
| Overlay_RightBottom = dataField+1000-2; // Custom overlay have a code LKValue+1000 | |||
| } | |||
|
|
|||
|
|
|||
| @@ -32,6 +32,7 @@ | |||
| #define RIGHTMARGIN NIBLSCALE(2) // spacing on right border | |||
| #define MAPSCALE_SIZE NIBLSCALE(46) | |||
|
|
|||
|
|
|||
| Surface.GetTextSize(BufferValue, &TextSize); | ||
| if (!HideUnits) { |
There was a problem hiding this comment.
wrong indent and GetTestSize() is costly, so don't call it if it's not needed
| @@ -634,11 +659,17 @@ void MapWindow::DrawLook8000(LKSurface& Surface, const RECT& rc) { | |||
| rcy = yrightoffset - SizeBigFont.cy +yoffset; | |||
|
|
|||
| LKWriteText(Surface, BufferValue, rcx, rcy, WTMODE_OUTLINED, WTALIGN_LEFT, OverColorRef, true); | |||
| if (!HideUnits) { | |||
| Surface.GetTextSize(BufferValue, &TextSize); | |||
| Surface.GetTextSize(BufferValue, &TextSize); | |||
There was a problem hiding this comment.
GetTestSize() is costly, so don't call it if it's not needed
| @@ -661,12 +692,16 @@ void MapWindow::DrawLook8000(LKSurface& Surface, const RECT& rc) { | |||
| Surface.SelectObject(LK8OverlayBigFont); | |||
| rcy=yrightoffset - fixBigInterline+yoffset; | |||
| LKWriteText(Surface, BufferValue, rcx, rcy, WTMODE_OUTLINED, WTALIGN_LEFT, OverColorRef, true); | |||
| Surface.GetTextSize(BufferValue, &TextSize); | |||
There was a problem hiding this comment.
GetTestSize() is costly, so don't call it if it's not needed
| } | ||
| LKWriteText(Surface, BufferValue, cx, cy, | ||
| WTMODE_OUTLINED, WTALIGN_RIGHT, OverColorRef, true); |
There was a problem hiding this comment.
LKWriteText called 2 time with same parameter if ScreenLandscape is false
| @@ -207,6 +207,7 @@ GEXTERN short Overlay_LeftDown; | |||
| GEXTERN short Overlay_RightTop; | |||
| GEXTERN short Overlay_RightMid; | |||
| GEXTERN short Overlay_RightBottom; | |||
| GEXTERN short Overlay_Title; | |||
There was a problem hiding this comment.
ON/OFF parameter should be "bool"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't do labels that on the right side,
-there is no units but maybe indicators
No good idea to make the right overlays free configurable, indicators do not change.
Therefore restricted configuration to OFF and default only