[frost] Fix features = alloc but not serde

LLFourn · Dec 12, 2022 · fa1eebc · fa1eebc
1 parent da6ffd2
commit fa1eebc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -105,7 +105,7 @@ jobs:
       - uses: actions-rs/cargo@v1
         with:
           command: test
-          args: --release --no-default-features --features alloc,serde -p ${{ matrix.package }}
+          args: --release --no-default-features --features alloc -p ${{ matrix.package }}
 
 
   doc-build:

diff --git a/schnorr_fun/src/frost.rs b/schnorr_fun/src/frost.rs
@@ -279,18 +279,21 @@ impl core::fmt::Display for FinishKeyGenError {
 impl std::error::Error for FinishKeyGenError {}
 
 /// A joint FROST key
-#[derive(Clone, Debug, PartialEq)]
+#[derive(Clone, Debug, PartialEq, Eq)]
 #[cfg_attr(
     feature = "serde",
     derive(crate::serde::Deserialize, crate::serde::Serialize),
     serde(crate = "crate::serde")
 )]
 pub struct FrostKey<T: PointType> {
     /// The joint public key of the frost multisignature.
-    #[serde(bound(
-        deserialize = "Point<T>: crate::serde::de::Deserialize<'de>",
-        serialize = "Point<T>: crate::serde::Serialize"
-    ))]
+    #[cfg_attr(
+        feature = "serde",
+        serde(bound(
+            deserialize = "Point<T>: crate::serde::de::Deserialize<'de>",
+            serialize = "Point<T>: crate::serde::Serialize"
+        ))
+    )]
     public_key: Point<T>,
     /// Everyone else's point polynomial evaluated at your index, used in partial signature validation.
     verification_shares: Vec<Point<Normal, Public, Zero>>,