How to generate empty input value with shadow?

[greenSnot]

I am going to implement this feature #904, The problem is

this.appendValueInput(param_name);

shows nothing but I expect to be rounded shadow (empty input)

    var opt:BlockRegisOpt = {
      is_procedure_call: true,
      id: '__PROCEDURE_CALL__' + name,
      type: p.output_type ? 'procedure_call_return' : 'procedure_call_no_return',
      message0: '%1',
      args0: [{
        type: 'field_label',
        name: 'NAME',
      }],
      previous_statement: p.output_type ? false : true ,
      next_statement: p.output_type ? false : true,
      //TODO
      output: p.output_type ? 'String' : undefined,
      category: 'procedure',
      xml: `
        <field name="NAME"></field>
      `,
      mutation_to_dom: function() {
        var container = document.createElement('mutation');
        this.setFieldValue(name, 'NAME');
        for (let param_name in procedure_map[name].params) {
          var parameter = document.createElement('param');
          parameter.setAttribute('name', param_name);
          container.appendChild(parameter);
          if (!this.getInput(param_name)) {
            let input = this.appendValueInput(param_name);
            //let field = new Blockly.FieldTextInput(i);
            //input.appendField(field);
          }
        }
        return container;
      },
      dom_to_mutation: function(element) {
        let param_list = element.getElementsByTagName('param');
        this.params = [];
        for (var i = 0; i < param_list.length; i++) {
          this.params.push(param_list[i].getAttribute('name'));
        }
        //TODO
      },
    };

[thisandagain]

Tracking feature request in scratchfoundation/scratch-vm#79

[greenSnot]

@thisandagain they are different issues. This seems like a bug? I am not sure, I just want to make a empty input.

[rachel-fenichel]

@greenSnot in your XML, add a shadow block to it and see if it renders correctly.

[greenSnot]

@rachel-fenichel , I want to append an empty input after Block.jsonInit. Is that possible?

[greenSnot]

@rachel-fenichel Oh, and If I define procedure block "MethodA with parameter x" and "MethodB with parameter x,y,z" they are both "procedure_call" type but different number of input value. So I can't do it in its xml & args0 before jsonInit.

[rachel-fenichel]

I see. Then this is a design question, about what block shapes are valid, so I'll defer to the scratch team.

[greenSnot]

Solved:)
@rachel-fenichel you might need this in core/block.js

  Blockly.Block.prototype.appendShadow_ = function(type, name) {
    var connection = this.makeConnection_(type);
    var input = new Blockly.Input(type, name, this, connection);
    this.inputList.push(input);
    var blocks = this.getDescendants();
    for (let i = 0; i < blocks.length; i++) {
      blocks[i].initSvg();
      blocks[i].render(false);
    }
    this.updateDisabled();
    Blockly.resizeSvgContents(this.workspace);
    return input;
  };