Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sign-in text when in the Scratch Editor #3947

Closed
techwonder21 opened this issue Dec 4, 2018 · 3 comments
Closed

Update Sign-in text when in the Scratch Editor #3947

techwonder21 opened this issue Dec 4, 2018 · 3 comments

Comments

@techwonder21
Copy link

Expected Behavior

Sign-in text should be the same across both the Project Page and Scratch Editor
projectpage

Actual Behavior

Sign-in text on the Scratch Editor is different than the Project Page
scratcheditor

Steps to Reproduce

  1. Visit a Scratch project in 3.0
  2. Change "project" to "preview"
    https://scratch.mit.edu/preview/237965780/editor/
  3. Click the "Sign in" button while in the Scratch Editor and notice the text "general.username, general.password, general.signIn, login.needHelp"
  4. Click the "See Community" button, then click the "Sign in" button and notice the correct sign-in text.

Operating System and Browser

Chrome 70, macOS High Sierra

@techwonder21
Copy link
Author

@thisandagain
Copy link
Contributor

thisandagain commented Dec 4, 2018

@benjiwheeler @chrisgarrity I'm fairly certain this is already being tracked, but couldn't find it. Can you please prioritize?

@benjiwheeler
Copy link
Contributor

#3601 exists; this should have been solved by #3602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants