Fix webpack dev server #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 10, 2017 14:39
This change tweaks the expression of paths in the Webpack config to make `webpack-dev-server` work again. This opened the door for some minor cleanup of `path` & `filename` in the `output` configuration entries. Thanks to @rschamp for help resolving the `webpack-dev-server` problems.
rschamp
approved these changes
Jan 11, 2017
thisandagain
approved these changes
Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tweaks the expression of paths in the Webpack config to make
webpack-dev-serverwork again. This opened the door for some minor cleanup ofpath&filenamein theoutputconfiguration entries.Thanks to @rschamp for help resolving the
webpack-dev-serverproblems.Also, enable source maps.
@rschamp and I discussed removing the Node target since we're not really using it right now, but I decided not to do that just yet. If/when we do remove it we should also make a few other changes, such as simplifying
src/index*.js.