Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std::accumulate calls #144

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix std::accumulate calls #144

merged 1 commit into from
Apr 20, 2022

Conversation

ndryden
Copy link
Collaborator

@ndryden ndryden commented Apr 19, 2022

Some calls to std::accumulate could overflow by accumulating size_ts into ints. This fixes them.

h/t @benson31 for pointing it out.

@ndryden
Fix accumulation type for several std::accumulate calls.
cd2c3dd 
These calls could potentially overflow, because they would accumulate
size_ts into ints.
@ndryden ndryden added the bug Something isn't working label Apr 19, 2022
@ndryden ndryden requested a review from benson31 April 19, 2022 20:11
benson31
benson31 approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ndryden ndryden merged commit 40a062b into master Apr 20, 2022
@ndryden ndryden deleted the fix-accumulate branch April 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benson31 benson31 benson31 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndryden @benson31