Fix a variety of build issues with ROCm 5 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benson31
added
bug
benson31
force-pushed
the
rocm-5-cmake-patch
branch
from
0ea9a9a
to
b07739b
Compare
benson31
force-pushed
the
rocm-5-cmake-patch
branch
from
b07739b
to
72ce79c
Compare
|
Builds for me. |
ndryden
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues in play here.
First, there seems to be an issue with finding the ROCm clang builtins and include paths. So we just find them and replace any "NOTFOUND" values in the relevant targets.
Second, the benchmarks and tests take approximately 1 hour per enabled backend when compiling with ANY optimization level more than "-O0". So we force that for the benchmarks when building in "DEBUG" mode. Release builds are unaffected, and the Aluminum library will be compiled with "-Og" still.