-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LDMS Connector/Forwarder #518
Conversation
Adding LDMS calls to CMakeLists
Adding the Caliper-LDMS connector/forwarder and CMakeLists files to services directory.
Adding LDMS Libraries to CMakeList to allow cali-query to identify LDMS publish functions.
Thanks for the PR @vsurjadidjaja ! I've noticed a few things:
|
Taking out unnecessary LDMS lib link
Adding LDMS path to README instructions.
This avoids seg faulting the program if user's do not set LDMS's env variables.
Hi @daboehme!! Thank you for taking a looking at my PR. I've rebased my fork to upstream/main. Please let me know if that's correct. I've also changed all messages to Caliper's logging format. To resolve the change I made in cali-query's CMakeLists.txt, I added two env variables in the README that instructs users to set the LD_LIBRARY_PATH and PATH so that Caliper can find LDMS's lib, bin, and sbin based on where the user installs LDMS. |
Hi @vsurjadidjaja , thanks again for the PR! I fixed a few things in the top-level CMakeLists.txt that were still somehow reverting some changes in the main branch, but otherwise it looks good to me! I'll merge it in. I'll try to find a machine with LDMS here where I can give this a spin. |
Adding the LDMS connector/forwarder and all necessary support files.