Remove remnants of RAJA module usage

[kab163]

After reviewing PR #1119, we discovered that the -fmodules flag was never actually being used. Although a user could turn on ENABLE_MODULES, the if statement in SetUpCompiler.cmake only checked a non-existent "RAJA_ENABLE_MODULES" option, making the if statement never evaluate to true and the -fmodules flag was never used. However, PR #1119 created a RAJA_ENABLE_MODULES option, and we discovered this broke the RAJA build.

That option was subsequently taken out of the PR branch, but we should document in the user guide how to enable the modules for CMake and regular make based build systems. This should be done for the next release.

[kab163]

@rhornung67 David made the point that since the ENABLE_MODULES flag never worked in RAJA develop, nobody was really using it anyways. The cmake prefix PR exposed this bug and took out the modules option, but just in case anybody does try to use the new version of that flag, RAJA_ENABLE_MODULES, it gives the deprecated warning and a message that the "-fmodules" flag could be added manually.

RAJA/cmake/SetupCompilers.cmake

Lines 12 to 15 in 39703eb

	if (RAJA_ENABLE_MODULES)
	message(WARNING "RAJA_ENABLE_MODULES is deprecated, please add the -fmodules flag manually if desired.")
	set(RAJA_ENABLE_MODULES Off CACHE BOOL "" FORCE)
	endif()

Given all that, do you think any more should be done to document this?

[kab163]

One note though - maybe we should remove the module map file stuff after next release (so maybe there is something to do for this issue - almost forgot about that).

[rhornung67]

We need to rip this stuff out.

[rhornung67]

@kab163 this can be closed, right?

[kab163]

@kab163 this can be closed, right?

yes!

[kab163]

Fixed with #1592