Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing module map stuff #1592

Merged
merged 3 commits into from
Jan 30, 2024
Merged

removing module map stuff #1592

merged 3 commits into from
Jan 30, 2024

Conversation

kab163
Copy link
Contributor

@kab163 kab163 commented Jan 24, 2024

Summary

@davidbeckingsale
Copy link
Member

I think you should also delete the files themselves.

@kab163
Copy link
Contributor Author

kab163 commented Jan 24, 2024

@rhornung67 - We talked about this issue yesterday at the RAJA meeting. I totally forgot about it! I removed what I thought I needed to and couldn't find any other mentions of the modulemap stuff - is this pretty much what is needed for fix this issue or is there something else to add?

(And just deleted the two module files given David's comment)

@kab163
Copy link
Contributor Author

kab163 commented Jan 24, 2024

I think you should also delete the files themselves.

Haha yes that makes sense :p thanks

Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kab163 I also forgot about this and the issue was assigned to me 👎

@rhornung67 rhornung67 merged commit 1a103cd into develop Jan 30, 2024
23 checks passed
@rhornung67 rhornung67 deleted the task/kab163/remove-modules branch January 30, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants