Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove set/getQueue methods for SYCL, part 1 #1652

Closed
4 tasks done
rhornung67 opened this issue May 22, 2024 · 0 comments · Fixed by #1653
Closed
4 tasks done

Remove set/getQueue methods for SYCL, part 1 #1652

rhornung67 opened this issue May 22, 2024 · 0 comments · Fixed by #1653
Assignees
@rhornung67
Labels
sycl support sycl backend support task

Comments

@rhornung67
Copy link
Member

rhornung67 commented May 22, 2024 •
edited

The RAJA setQueue and getQueue methods are a remnant from before we were able to pass a resource to RAJA kernel execution methods. These should be removed and instead pass a resource to kernel execution methods for consistency.

  • policy/sycl/forall.hpp
  • policy/sycl/launch.hpp
  • policy/sycl/kernel/internal.hpp
  • policy/sycl/kernel/SyclKernel.hpp
@rhornung67 rhornung67 added task sycl support sycl backend support labels May 22, 2024
@rhornung67 rhornung67 self-assigned this May 22, 2024
@rhornung67 rhornung67 mentioned this issue May 22, 2024
Merged
@rhornung67 rhornung67 changed the title Remove set/getQueue methods for SYCL Remove set/getQueue methods for SYCL, part 1 May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhornung67 rhornung67

Labels
sycl support sycl backend support task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependences on RAJA internal set/getQueue methods LLNL/RAJA
1 participant
@rhornung67