Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependences on RAJA internal set/getQueue methods #1653

Merged
merged 8 commits into from
Jun 3, 2024

Conversation

rhornung67
Copy link
Member

@rhornung67 rhornung67 commented May 22, 2024

Summary

  • This PR eliminates the need to use the internal set/getQueue methods in some parts of RAJA SYCL support.
  • There is more work to be done, briefly described in Remove SYCL set/getQueue methods, part 2 #1658.
  • The content of this PR is required to enable correct asynchronous execution of RAJA Perf kernels that use the RAJA::kernel interface. The associated PR that adds many SYCL kernel variants to RAJA Perf is Add SYCL kernels RAJAPerf#441.

Passing resources explicitly to kernel execution methods results in consistent SYCL resource/queue usage during execution of most kernels as a result. getQueue method calls have been removed in some places as a result. When a resource is not passed to a kernel execution method, the code can now properly acquire the default SYCL resource via execution policy type traits without relying on internal getQueue calls.

Resolves #1652

@rhornung67 rhornung67 changed the title [WIP] Attempting to remove dependence on RAJA internal set/getQueue methods Remove dependences on RAJA internal set/getQueue methods May 31, 2024
@rhornung67 rhornung67 merged commit b002911 into develop Jun 3, 2024
24 checks passed
@rhornung67 rhornung67 deleted the task/rhornung67/sycl-resource-cleanup branch June 3, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove set/getQueue methods for SYCL, part 1
4 participants