Pull in changes to fix separable compilation for CUDA or HIP. #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update release info to do a patch release.
rhornung67
requested review from
trws,
MrBurmark,
artv3,
mdavis36 and
rchen20
MrBurmark
approved these changes
Feb 23, 2023
|
@rhornung67, I'm testing this out today in my application. |
|
@rhornung67, this works for my application with CMAKE_CUDA_SEPARABLE_COMPILATION=ON. |
adayton1
reviewed
Feb 28, 2023
RELEASE_NOTES.md
Outdated
| @@ -19,7 +19,17 @@ Notable changes include: | |||
|
|
|||
| * Bug fixes/improvements: | |||
|
|
|||
| Version 2022.10.4 -- Release date 2022-14-01 | |||
| Version 2022.10.5 -- Release date 2023-02-xx | |||
There was a problem hiding this comment.
Does this date need to be updated?
There was a problem hiding this comment.
Yeah, I saw that and have a local fix I need to push.
mdavis36
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary