Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes for sycl #1640

Closed
wants to merge 4 commits into from
Closed

Bugfixes for sycl #1640

wants to merge 4 commits into from

Conversation

artv3
Copy link
Member

@artv3 artv3 commented May 7, 2024

Address two bugs in SYCL launch backend

  1. Ensures async boolean works properly
  2. Eliminates memory leaks when using non-trivially copyable lambdas.

@artv3 artv3 requested review from rhornung67 and mdavis36 May 7, 2024 17:35
@artv3 artv3 marked this pull request as ready for review May 7, 2024 17:35
@artv3 artv3 closed this May 10, 2024
@artv3 artv3 reopened this May 10, 2024
@artv3
Copy link
Member Author

artv3 commented May 10, 2024

I'm going to close this PR in favor of a new one. Hopefully the new PR will have better luck with the CI.

@artv3 artv3 closed this May 10, 2024
@artv3 artv3 deleted the artv3/sycl-launch-bugfixes branch May 10, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhornung67 rhornung67 rhornung67 approved these changes

@mdavis36 mdavis36 Awaiting requested review from mdavis36

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@artv3 @rhornung67