HALOEXCHANGE_FUSED WorkGroup Dispatch Policies #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
requested review from
artv3,
rhornung67,
CRobeck,
rchen20 and
robinson96
MrBurmark
changed the title
7 tasks
It now takes a camp::list of types and calls the function with a default initialized object of each type in order. Gpu block sizes were changed from integer sequences to lists of integral constants to work with the changes.
Make a templated member function to handle different tunings.
MrBurmark
force-pushed
the
feature/burmark1/fusable_direct_dispatch
branch
from
28c07fc
to
a2e0b75
Compare
MrBurmark
changed the title
|
I've discovered one potential down side to abstracting the workgroup implementation. I can no longer use lambdas in the RAJA variants because the templated function has to support direct dispatch polices and indirect policies. The direct polices require fore-knowledge of the types used so I end up using functional classes instead of lambdas. Previously the indirect polices where in their own function so they used lambdas. I will be able to use |
rhornung67
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new Dispatch policies in HALOEXCHANGE_FUSED.
This demonstrates the work group dispatch policies added to RAJA.
Based on changes in RAJA PR LLNL/RAJA#1320.